Remove "inline" from library models [blocks: #6863] #6901
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
changed the title
kroening
approved these changes
Jun 1, 2022
tautschnig
force-pushed
the
bugfixes/library-no-inline
branch
from
8001f89 to
d349380
Compare
Codecov Report
@@ Coverage Diff @@
## develop #6901 +/- ##
========================================
Coverage 77.81% 77.82%
========================================
Files 1568 1568
Lines 179975 180004 +29
========================================
+ Hits 140044 140081 +37
+ Misses 39931 39923 -8
Continue to review full report at Codecov.
|
Avoid unnecessary warnings about malloc not being declared. The resulting type conflict may also trip up the analysis, and is only worked around by inlining calls to malloc.
Instead, add the missing _mm_adds_epu16.
It nowadays has no effect for we don't do partial inlining by default anymore. It does, however, trip up the library check on Ubuntu 22.04 as fopen, fclose, fdopen are marked with attribute "noinline" in the system library. The only exception is goto-analyzer, which still does partial inlining. Therefore, keep "malloc" marked "inline" to ensure the analyses do not need to track allocations across functions. The full fix, however, is for goto-analyzer to selectively do inlining.
tautschnig
force-pushed
the
bugfixes/library-no-inline
branch
from
d349380 to
4057726
Compare
tautschnig
added a commit
that referenced
this pull request
Jun 4, 2022
GitHub actions: Ubuntu 22.04 [depends-on: #6901]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It nowadays has no effect for we don't do partial inlining by default
anymore. It does, however, trip up the library check on Ubuntu 22.04 as
fopen, fclose, fdopen are marked with attribute "noinline" in the system
library.
Please review commit-by-commit: the second one is clang-format provided re-formatting only.