Cleanup of goto_instrument_parse_optionst::instrument_goto_program #6897
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no need to declare in a parent scope what is only used in a single branch.
The unwinding done by goto-instrument is configured elsewhere and makes no use of this option parsing. It used to be used by weak-memory instrumentation, but this is no longer the case.
Just like CBMC, we need to make sure that library functions called via inline assembly are resolved.
… and loop skipping Adding additional code should be the first order of business, and all transformations can only be applied thereafter to make sure they equally apply to library code.
Codecov Report
@@ Coverage Diff @@
## develop #6897 +/- ##
===========================================
- Coverage 77.81% 77.81% -0.01%
===========================================
Files 1568 1568
Lines 179985 179982 -3
===========================================
- Hits 140054 140050 -4
- Misses 39931 39932 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review commit-by-commit.