-
Notifications
You must be signed in to change notification settings - Fork 274
XML counterexample trace: display member types #6869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
XML counterexample trace: display member types #6869
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #6869 +/- ##
===========================================
- Coverage 77.80% 77.80% -0.01%
===========================================
Files 1567 1567
Lines 179916 179917 +1
===========================================
Hits 139988 139988
- Misses 39928 39929 +1
Continue to review full report at Codecov.
|
Would it make sense to call that full_lhs_type, to avoid ambiguity? |
Done. |
a301076
to
ea35d4e
Compare
Field-sensitive SSA yields assignments at member/element level. The XML counterexamples, however, appeared to (continue to) assume that all assignments take place at object level. Adjust the type (which is only included in XML output, not in JSON nor plain output) to match that of the element being assigned.
ea35d4e
to
6d7269d
Compare
@@ -39,7 +39,7 @@ | |||
<xs:complexType> | |||
<xs:all> | |||
<xs:element ref="location" minOccurs="0"/> | |||
<xs:element name="type" type="xs:string" minOccurs="0"/> | |||
<xs:element name="full_lhs_type" type="xs:string" minOccurs="0"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TGWDB ^ Change in the XML specification
Field-sensitive SSA yields assignments at member/element level. The XML
counterexamples, however, appeared to (continue to) assume that all
assignments take place at object level. Adjust the type (which is only
included in XML output, not in JSON nor plain output) to match that of
the element being assigned.