Skip to content

XML counterexample trace: display member types #6869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 7, 2022

Conversation

tautschnig
Copy link
Collaborator

Field-sensitive SSA yields assignments at member/element level. The XML
counterexamples, however, appeared to (continue to) assume that all
assignments take place at object level. Adjust the type (which is only
included in XML output, not in JSON nor plain output) to match that of
the element being assigned.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@codecov
Copy link

codecov bot commented May 19, 2022

Codecov Report

Merging #6869 (6d7269d) into develop (bcca9da) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #6869      +/-   ##
===========================================
- Coverage    77.80%   77.80%   -0.01%     
===========================================
  Files         1567     1567              
  Lines       179916   179917       +1     
===========================================
  Hits        139988   139988              
- Misses       39928    39929       +1     
Impacted Files Coverage Δ
src/goto-programs/xml_goto_trace.cpp 99.41% <100.00%> (+<0.01%) ⬆️
src/ansi-c/expr2c.cpp 67.58% <0.00%> (-0.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c688efd...6d7269d. Read the comment docs.

@kroening
Copy link
Member

Would it make sense to call that full_lhs_type, to avoid ambiguity?

@tautschnig tautschnig self-assigned this May 23, 2022
@tautschnig
Copy link
Collaborator Author

Would it make sense to call that full_lhs_type, to avoid ambiguity?

Done.

@tautschnig tautschnig force-pushed the bugfixes/6845-part-1-xml branch 2 times, most recently from a301076 to ea35d4e Compare May 23, 2022 21:11
@tautschnig tautschnig requested a review from chris-ryder as a code owner May 23, 2022 21:11
@tautschnig tautschnig removed their assignment May 24, 2022
Field-sensitive SSA yields assignments at member/element level. The XML
counterexamples, however, appeared to (continue to) assume that all
assignments take place at object level. Adjust the type (which is only
included in XML output, not in JSON nor plain output) to match that of
the element being assigned.
@tautschnig tautschnig force-pushed the bugfixes/6845-part-1-xml branch from ea35d4e to 6d7269d Compare May 25, 2022 22:44
@@ -39,7 +39,7 @@
<xs:complexType>
<xs:all>
<xs:element ref="location" minOccurs="0"/>
<xs:element name="type" type="xs:string" minOccurs="0"/>
<xs:element name="full_lhs_type" type="xs:string" minOccurs="0"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TGWDB ^ Change in the XML specification

@tautschnig tautschnig requested a review from TGWDB June 1, 2022 06:58
@tautschnig tautschnig merged commit 3b340ad into diffblue:develop Jun 7, 2022
@tautschnig tautschnig deleted the bugfixes/6845-part-1-xml branch June 7, 2022 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants