Skip to content

introduce goto_instruction_codet #6854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2022
Merged

Conversation

kroening
Copy link
Member

This introduces an alias for codet for use in goto_instructiont, to convey
the information that goto_instructiont expects a specific subset of the
codet types.

It is anticipated that goto_instruction_codet will eventually be a distinct
type.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@kroening kroening force-pushed the goto_instruction_codet branch from 93e0c2f to fd4e76e Compare May 13, 2022 02:53
This introduces an alias for codet for use in goto_instructiont, to convey
the information that goto_instructiont expects a specific subset of the
codet types.

It is anticipated that goto_instruction_codet will eventually be a distinct
type.
@kroening kroening force-pushed the goto_instruction_codet branch from fd4e76e to 0de72ad Compare May 13, 2022 02:54
@codecov
Copy link

codecov bot commented May 13, 2022

Codecov Report

Merging #6854 (0de72ad) into develop (a188777) will increase coverage by 0.00%.
The diff coverage is 97.82%.

@@           Coverage Diff            @@
##           develop    #6854   +/-   ##
========================================
  Coverage    77.79%   77.79%           
========================================
  Files         1567     1567           
  Lines       179707   179713    +6     
========================================
+ Hits        139797   139803    +6     
  Misses       39910    39910           
Impacted Files Coverage Δ
src/goto-programs/goto_program.h 90.27% <94.11%> (+0.02%) ⬆️
src/goto-programs/goto_instruction_code.h 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58d64d8...0de72ad. Read the comment docs.

@kroening kroening marked this pull request as ready for review May 13, 2022 04:20
@tautschnig tautschnig merged commit 6e0e0fa into develop May 13, 2022
@tautschnig tautschnig deleted the goto_instruction_codet branch May 13, 2022 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants