CONTRACTS: Support object slices in assigns clauses #6814
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remi-delmas-3000
requested review from
tautschnig,
feliperodri,
SaswatPadhi,
kroening and
chris-ryder
as code owners
remi-delmas-3000
force-pushed
the
contracts-object-slice
branch
from
0a184c6 to
4d0d4f3
Compare
Codecov Report
@@ Coverage Diff @@
## develop #6814 +/- ##
========================================
Coverage 77.00% 77.01%
========================================
Files 1594 1594
Lines 184345 184413 +68
========================================
+ Hits 141957 142020 +63
- Misses 42388 42393 +5
Continue to review full report at Codecov.
|
remi-delmas-3000
force-pushed
the
contracts-object-slice
branch
from
4d0d4f3 to
384dd30
Compare
tautschnig
approved these changes
Apr 20, 2022
src/ansi-c/c_typecheck_code.cpp
Outdated
Comment on lines
922
to
936
| if(has_subexpr(target, ID_side_effect)) | ||
| { | ||
| error().source_location = target.source_location(); | ||
| error() << "side-effects not allowed in assigns clause targets" << eom; | ||
| throw 0; | ||
| } | ||
| if(has_subexpr(target, ID_if)) | ||
| { | ||
| error().source_location = target.source_location(); | ||
| error() << "ternary expressions not allowed in assigns " | ||
| "clause targets" | ||
| << eom; | ||
| throw 0; | ||
| } |
There was a problem hiding this comment.
This repeats multiple times and might be worth factoring out into a static function.
There was a problem hiding this comment.
factored it using a local lambda
feliperodri
changed the title
remi-delmas-3000
force-pushed
the
contracts-object-slice
branch
2 times, most recently
from
05710dd to
2a53c59
Compare
Introduces __CPROVER_object_from and __CPROVER_object_slice target expression in assigns clauses. Both get compiled to __CPROVER_havoc_slice for contract replacement.
remi-delmas-3000
force-pushed
the
contracts-object-slice
branch
from
2a53c59 to
0bb6993
Compare
feliperodri
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support the following targets in assigns clauses:
__CPROVER_object_from(ptr): allows to assign all remaining bytes of the object, starting at the given address.__CPROVER_object_slice(ptr, size): allows to assign size bytes of the object starting at the given address.Both targets are translated to
__CPROVER_havoc_slicefor contract replacement.