rename_symbolt: renaming in return values should affect the result

[tautschnig]

If users want to check whether any renaming took place, they need to be
informed in case that renaming took place in the type of the return
value of a code_typet.

Only function_name_manglert currently checks this result value, but none
of its current use would really result in renaming within a return
value.

• Each commit message has a non-empty body, explaining why the change was made.
• n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
• n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
• Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
• n/a My commit message includes data points confirming performance improvements (if claimed).
• My PR is restricted to a single feature or bugfix.
• n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

[codecov]

Codecov Report

Merging #6809 (9b8a24b) into develop (aed93c8) will increase coverage by 0.00%.
The diff coverage is 97.64%.

@@           Coverage Diff            @@
##           develop    #6809   +/-   ##
========================================
  Coverage    76.99%   76.99%           
========================================
  Files         1594     1594           
  Lines       184263   184317   +54     
========================================
+ Hits        141872   141924   +52     
- Misses       42391    42393    +2     

Impacted Files	Coverage Δ
src/solvers/smt2/smt2_conv.h	100.00% <ø> (ø)
...c/solvers/smt2_incremental/convert_expr_to_smt.cpp	84.53% <0.00%> (-0.35%)	⬇️
src/util/simplify_expr_class.h	90.47% <ø> (ø)
src/util/std_expr.h	93.18% <ø> (ø)
src/ansi-c/c_typecheck_expr.cpp	77.05% <100.00%> (-0.02%)	⬇️
src/ansi-c/goto_check_c.cpp	91.47% <100.00%> (ø)
src/solvers/flattening/bv_pointers.cpp	83.09% <100.00%> (ø)
src/solvers/smt2/smt2_conv.cpp	67.47% <100.00%> (-0.02%)	⬇️
src/util/pointer_expr.h	84.64% <100.00%> (+0.77%)	⬆️
src/util/pointer_predicates.cpp	93.10% <100.00%> (ø)
... and 4 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c58a89...9b8a24b. Read the comment docs.