Skip to content

Add missing <functional> include [blocks: #6749] #6764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 26, 2022

Conversation

tautschnig
Copy link
Collaborator

Headers should include what they, and not rely on nonstd/optional to
provide the header.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Headers should include what they, and not rely on nonstd/optional to
provide the header.
@codecov
Copy link

codecov bot commented Mar 25, 2022

Codecov Report

Merging #6764 (dea6182) into develop (57a8097) will increase coverage by 0.00%.
The diff coverage is 77.77%.

@@           Coverage Diff            @@
##           develop    #6764   +/-   ##
========================================
  Coverage    76.89%   76.90%           
========================================
  Files         1590     1590           
  Lines       183979   183963   -16     
========================================
- Hits        141478   141477    -1     
+ Misses       42501    42486   -15     
Impacted Files Coverage Δ
...o-instrument/accelerate/polynomial_accelerator.cpp 0.00% <0.00%> (ø)
...oto-instrument/accelerate/polynomial_accelerator.h 100.00% <ø> (ø)
src/goto-programs/resolve_inherited_component.h 100.00% <ø> (ø)
src/solvers/flattening/boolbv.h 62.50% <ø> (ø)
src/solvers/flattening/boolbv_map.h 100.00% <ø> (ø)
src/util/expr.h 97.22% <ø> (ø)
src/solvers/flattening/boolbv_overflow.cpp 48.68% <76.00%> (-1.91%) ⬇️
src/solvers/flattening/boolbv.cpp 80.39% <80.00%> (-0.18%) ⬇️
src/analyses/goto_rw.cpp 63.28% <100.00%> (+0.45%) ⬆️
src/util/simplify_expr_array.cpp 90.72% <100.00%> (+0.19%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31f1b59...dea6182. Read the comment docs.

@tautschnig tautschnig changed the title Add missing <functional> include Add missing <functional> include [blocks: #6749] Mar 25, 2022
@kroening kroening merged commit e0afa1f into diffblue:develop Mar 26, 2022
@tautschnig tautschnig deleted the cleanup/functional branch March 26, 2022 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants