Skip to content

Disambiguate overloaded insert(...) calls [blocks: #6749] #6755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 17, 2022

Conversation

tautschnig
Copy link
Collaborator

Once we move to std::optional, the use of int results in an ambiguous
overload resolution. Avoid that by explicitly constructing an
mp_integer.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Once we move to std::optional, the use of int results in an ambiguous
overload resolution. Avoid that by explicitly constructing an
mp_integer.
@codecov
Copy link

codecov bot commented Mar 24, 2022

Codecov Report

Merging #6755 (6aca25c) into develop (c0f179c) will increase coverage by 0.02%.
The diff coverage is 84.55%.

@@             Coverage Diff             @@
##           develop    #6755      +/-   ##
===========================================
+ Coverage    76.87%   76.89%   +0.02%     
===========================================
  Files         1590     1590              
  Lines       183887   183978      +91     
===========================================
+ Hits        141364   141477     +113     
+ Misses       42523    42501      -22     
Impacted Files Coverage Δ
src/ansi-c/goto_check_c.cpp 91.47% <ø> (-0.15%) ⬇️
src/pointer-analysis/value_set_fi.cpp 69.78% <50.00%> (ø)
...c/solvers/smt2_incremental/convert_expr_to_smt.cpp 72.09% <79.48%> (+3.07%) ⬆️
src/pointer-analysis/value_set.cpp 83.33% <83.33%> (+0.02%) ⬆️
src/analyses/goto_rw.cpp 62.83% <100.00%> (+0.47%) ⬆️
src/goto-programs/builtin_functions.cpp 58.35% <100.00%> (+1.48%) ⬆️
src/util/pointer_expr.h 80.68% <100.00%> (ø)
src/util/simplify_expr_int.cpp 85.59% <100.00%> (ø)
src/util/std_expr.h 93.66% <0.00%> (+0.18%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 629d029...6aca25c. Read the comment docs.

@tautschnig tautschnig changed the title Disambiguate overloaded insert(...) calls Disambiguate overloaded insert(...) calls [blocks: #6749] Mar 25, 2022
@peterschrammel peterschrammel removed their assignment May 17, 2022
@tautschnig tautschnig merged commit e6b943f into diffblue:develop May 17, 2022
@tautschnig tautschnig deleted the cleanup/overload branch May 17, 2022 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants