Skip to content

Simplify index: ensure consistent types #6746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2022

Conversation

tautschnig
Copy link
Collaborator

When computing a new offset for a byte extract, do not implicitly assume
that byte-extract offsets and array index operations use exactly the
same type for we don't prescribe the type to use as a byte-extract
offset.

Fixes: #6298

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

When computing a new offset for a byte extract, do not implicitly assume
that byte-extract offsets and array index operations use exactly the
same type for we don't prescribe the type to use as a byte-extract
offset.

Fixes: diffblue#6298
@codecov
Copy link

codecov bot commented Mar 22, 2022

Codecov Report

Merging #6746 (bdf877d) into develop (5c25144) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop    #6746   +/-   ##
========================================
  Coverage    76.86%   76.86%           
========================================
  Files         1589     1589           
  Lines       183814   183822    +8     
========================================
+ Hits        141293   141302    +9     
+ Misses       42521    42520    -1     
Impacted Files Coverage Δ
src/util/simplify_expr_array.cpp 90.72% <100.00%> (+0.19%) ⬆️
src/util/simplify_expr_int.cpp 85.59% <100.00%> (+0.09%) ⬆️
src/util/piped_process.cpp 83.13% <0.00%> (+1.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 724467c...bdf877d. Read the comment docs.

@tautschnig tautschnig merged commit 7216c65 into diffblue:develop Mar 24, 2022
@tautschnig tautschnig deleted the bugfixes/6298-index-types branch March 24, 2022 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invariant violation 'convert_mult'
3 participants