Skip to content

Lift alloca's deallocation behaviour out of goto_check_ct #6743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 23, 2022

Conversation

tautschnig
Copy link
Collaborator

alloca always results in deallocation taking place, and not just when
pointer checks are enabled.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@codecov
Copy link

codecov bot commented Mar 21, 2022

Codecov Report

Merging #6743 (da65bce) into develop (5c25144) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop    #6743   +/-   ##
========================================
  Coverage    76.86%   76.86%           
========================================
  Files         1589     1589           
  Lines       183814   183829   +15     
========================================
+ Hits        141293   141308   +15     
  Misses       42521    42521           
Impacted Files Coverage Δ
src/ansi-c/goto_check_c.cpp 91.47% <ø> (-0.15%) ⬇️
src/goto-programs/builtin_functions.cpp 58.35% <100.00%> (+1.48%) ⬆️
src/util/simplify_expr_int.cpp 85.59% <100.00%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 724467c...da65bce. Read the comment docs.

@kroening kroening assigned tautschnig and unassigned kroening Mar 22, 2022
@tautschnig tautschnig force-pushed the cleanup/alloca-processing branch from 60e6562 to c254fd6 Compare March 22, 2022 13:05
The multi-argument specification is to be used with add_test_pl_profile,
not add_test_pl_tests. Also, remove the spurious first argument that
resulted in 0 tests being found.
@tautschnig tautschnig force-pushed the cleanup/alloca-processing branch from c254fd6 to 4b9baa9 Compare March 22, 2022 22:05
alloca always results in deallocation taking place, and not just when
pointer checks are enabled.
@tautschnig tautschnig force-pushed the cleanup/alloca-processing branch from 4b9baa9 to da65bce Compare March 23, 2022 09:17
@tautschnig tautschnig merged commit f6054b5 into diffblue:develop Mar 23, 2022
@tautschnig tautschnig deleted the cleanup/alloca-processing branch March 23, 2022 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants