Skip to content

Download and install cvc5 from the binaries of the github release #6732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 19, 2022
Merged

Download and install cvc5 from the binaries of the github release #6732

merged 1 commit into from
Mar 19, 2022

Conversation

NlightNFotis
Copy link
Contributor

@NlightNFotis NlightNFotis commented Mar 15, 2022 •
edited
Loading

The aim of this PR is to install cvc5 on our GitHub actions
CI runners, so that we can use that later on to test our new
SMT backend against other solvers (previously, we tested only
against z3, which can create an implicit dependency on this).

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@NlightNFotis NlightNFotis self-assigned this Mar 15, 2022
@codecov
Copy link

codecov bot commented Mar 15, 2022 •
edited
Loading

Codecov Report

Merging #6732 (fff974c) into develop (56f317a) will not change coverage.
The diff coverage is n/a.

❗ Current head fff974c differs from pull request most recent head 3988924. Consider uploading reports for the commit 3988924 to get more accurate results

@@           Coverage Diff            @@
##           develop    #6732   +/-   ##
========================================
  Coverage    76.86%   76.86%           
========================================
  Files         1589     1589           
  Lines       183813   183813           
========================================
  Hits        141289   141289           
  Misses       42524    42524

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ca79bf...3988924. Read the comment docs.

@NlightNFotis NlightNFotis force-pushed the add_cvc_5_to_ci branch 2 times, most recently from cd58e51 to cd67273 Compare March 16, 2022 11:48
martin-cs
martin-cs approved these changes Mar 16, 2022
View reviewed changes
Copy link
Collaborator

@martin-cs martin-cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great to see!

.github/workflows/pull-request-checks.yaml Outdated
@@ -20,6 +20,11 @@ jobs:
sudo apt-get install --no-install-recommends -yq gcc gdb g++ maven jq flex bison libxml2-utils ccache cmake z3
- name: Confirm z3 solver is available and log the version installed
run: z3 --version
- name: Download cvc-5 from the releases page and make sure it can be deployed
run: |
wget https://github.com/cvc5/cvc5/releases/download/cvc5-0.0.7/cvc5-Linux
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to have a macro for the version number because I know the cvc5 release 1.00 is due soon?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Martin, I'll have a look to see if there's something I can do for this.

I think a macro may not be possible (in yaml), but maybe it's possible to store the version in a variable and do some string interpolation, which is going to concentrate the knowledge for the version in just one place, allowing for an easy update.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Any of these would be great, parallel changes to multiple instances of the same string always makes me nervous.

@NlightNFotis NlightNFotis marked this pull request as ready for review March 16, 2022 14:38
@NlightNFotis NlightNFotis requested a review from a team as a code owner March 16, 2022 14:38
thomasspriggs
thomasspriggs suggested changes Mar 17, 2022
View reviewed changes
@NlightNFotis NlightNFotis merged commit a50ef65 into diffblue:develop Mar 19, 2022
@NlightNFotis NlightNFotis deleted the add_cvc_5_to_ci branch March 19, 2022 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martin-cs martin-cs martin-cs approved these changes

@thomasspriggs thomasspriggs thomasspriggs approved these changes

Assignees

@NlightNFotis NlightNFotis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NlightNFotis @martin-cs @thomasspriggs