Skip to content

CONTRACTS: Remove helper method check_for_looped_mallocs #6729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

feliperodri
Copy link
Collaborator

We now inline functions with contracts during instrumentation,
so this method is no longer used.

Resolves #5530

Signed-off-by: Felipe R. Monteiro [email protected]

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

We now inline functions with contracts during instrumentation,
so this method is no longer used.

Signed-off-by: Felipe R. Monteiro <[email protected]>
@feliperodri feliperodri added cleanup Code Contracts Function and loop contracts labels Mar 14, 2022
@feliperodri feliperodri requested a review from tautschnig as a code owner March 14, 2022 16:55
@feliperodri feliperodri self-assigned this Mar 14, 2022
@codecov
Copy link

codecov bot commented Mar 14, 2022

Codecov Report

Merging #6729 (56f317a) into develop (9053c5f) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6729      +/-   ##
===========================================
+ Coverage    76.85%   76.86%   +0.01%     
===========================================
  Files         1589     1589              
  Lines       183846   183813      -33     
===========================================
  Hits        141289   141289              
+ Misses       42557    42524      -33     
Impacted Files Coverage Δ
src/goto-instrument/contracts/contracts.cpp 92.56% <ø> (+4.24%) ⬆️
src/goto-instrument/contracts/contracts.h 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f7f5ae...56f317a. Read the comment docs.

@tautschnig tautschnig merged commit 6ca79bf into diffblue:develop Mar 14, 2022
@feliperodri feliperodri deleted the remove-unused-function-from-contracts-module branch March 14, 2022 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code Contracts Function and loop contracts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve check_for_looped_mallocs in code contracts to use natural loops
3 participants