Skip to content

goto_rw: left shift may be larger than object size #6723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2022

Conversation

tautschnig
Copy link
Collaborator

While such an expression might have undefined behaviour in some source
languages, goto_rw should not assert that a goto program does not
contain such an expression.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@codecov
Copy link

codecov bot commented Mar 11, 2022

Codecov Report

Merging #6723 (542ce54) into develop (c0f179c) will increase coverage by 0.02%.
The diff coverage is 86.99%.

@@             Coverage Diff             @@
##           develop    #6723      +/-   ##
===========================================
+ Coverage    76.87%   76.89%   +0.02%     
===========================================
  Files         1590     1590              
  Lines       183887   183977      +90     
===========================================
+ Hits        141364   141478     +114     
+ Misses       42523    42499      -24     
Impacted Files Coverage Δ
src/ansi-c/goto_check_c.cpp 91.47% <ø> (-0.15%) ⬇️
...c/solvers/smt2_incremental/convert_expr_to_smt.cpp 72.09% <79.48%> (+3.07%) ⬆️
src/analyses/goto_rw.cpp 63.28% <100.00%> (+0.93%) ⬆️
src/goto-programs/builtin_functions.cpp 58.35% <100.00%> (+1.48%) ⬆️
src/util/pointer_expr.h 80.68% <100.00%> (ø)
src/util/simplify_expr_int.cpp 85.59% <100.00%> (ø)
src/util/std_expr.h 93.66% <0.00%> (+0.18%) ⬆️
src/util/bitvector_expr.h 97.28% <0.00%> (+0.54%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 629d029...542ce54. Read the comment docs.

While such an expression might have undefined behaviour in some source
languages, goto_rw should not assert that a goto program does not
contain such an expression.
@tautschnig tautschnig merged commit 31f1b59 into diffblue:develop Mar 24, 2022
@tautschnig tautschnig deleted the bugfixes/goto_rw-left-shift branch March 24, 2022 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants