goto_rw: do not assume that all types have constant size #6719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pointer_offset_bits returns nullopt whenever the size of a type is not a numeric constant. Such cases arise when arrays have runtime-determined size, as is the case in regression test byte_update5. All other places except the one fixed in this commit already considered the case that pointer_offset_bits returns nullopt.
tautschnig
requested review from
martin-cs,
peterschrammel and
chris-ryder
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #6719 +/- ##
===========================================
+ Coverage 76.80% 76.82% +0.01%
===========================================
Files 1589 1589
Lines 183658 183711 +53
===========================================
+ Hits 141056 141131 +75
+ Misses 42602 42580 -22
Continue to review full report at Codecov.
|
TGWDB
approved these changes
Mar 11, 2022
peterschrammel
approved these changes
Mar 23, 2022
| const exprt simp_offset=simplify_expr(be.offset(), ns); | ||
|
|
||
| auto index = numeric_cast<mp_integer>(simp_offset); | ||
| if(range_start == -1 || !index.has_value()) | ||
| if( | ||
| range_start == -1 || !index.has_value() || |
There was a problem hiding this comment.
Pull request forthcoming. Commit already exists, but depends on the various other PRs on this topic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pointer_offset_bits returns nullopt whenever the size of a type is not a
numeric constant. Such cases arise when arrays have runtime-determined
size, as is the case in regression test byte_update5.
All other places except the one fixed in this commit already considered
the case that pointer_offset_bits returns nullopt.