Skip to content

Remove goto_check_java #6686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

tautschnig
Copy link
Collaborator

The Java front-end instruments checks via other means. The only
remaining use of goto_check_javat was handling of the no-assertions
and no-assumptions command-line options, which is now handled by other
means.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@tautschnig tautschnig self-assigned this Feb 20, 2022
@tautschnig tautschnig force-pushed the cleanup/remove-goto_check_java branch from 958f4a7 to ef61441 Compare February 20, 2022 22:05
@tautschnig tautschnig changed the title Remove goto_check_java Remove goto_check_java [depends-on: #6687] Feb 20, 2022
@codecov
Copy link

codecov bot commented Feb 20, 2022

Codecov Report

Merging #6686 (6a76ae2) into develop (1154f13) will increase coverage by 0.16%.
The diff coverage is 95.34%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6686      +/-   ##
===========================================
+ Coverage    76.92%   77.09%   +0.16%     
===========================================
  Files         1583     1582       -1     
  Lines       183314   182647     -667     
===========================================
- Hits        141018   140813     -205     
+ Misses       42296    41834     -462     
Impacted Files Coverage Δ
jbmc/src/jdiff/jdiff_parse_options.h 100.00% <ø> (ø)
src/analyses/goto_check_c.cpp 91.59% <ø> (-0.02%) ⬇️
jbmc/src/jdiff/jdiff_parse_options.cpp 67.34% <71.42%> (-0.74%) ⬇️
jbmc/src/janalyzer/janalyzer_parse_options.cpp 48.74% <100.00%> (-0.01%) ⬇️
jbmc/src/jbmc/jbmc_parse_options.cpp 75.97% <100.00%> (-0.06%) ⬇️
src/analyses/goto_check.cpp 81.39% <100.00%> (+17.75%) ⬆️
.../goto-instrument/goto_instrument_parse_options.cpp 69.39% <100.00%> (+0.03%) ⬆️
src/goto-programs/process_goto_program.cpp 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e616881...6a76ae2. Read the comment docs.

The Java front-end instruments checks via other means. The only
remaining use of `goto_check_javat` was handling of the `no-assertions`
and `no-assumptions` command-line options, which is now handled by
`transform_assertions_assumptions`.
@tautschnig tautschnig force-pushed the cleanup/remove-goto_check_java branch from ef61441 to 6a76ae2 Compare February 25, 2022 12:58
@tautschnig tautschnig changed the title Remove goto_check_java [depends-on: #6687] Remove goto_check_java Feb 25, 2022
@tautschnig tautschnig marked this pull request as ready for review February 25, 2022 12:58
@kroening kroening merged commit b3d7721 into diffblue:develop Feb 27, 2022
@tautschnig tautschnig deleted the cleanup/remove-goto_check_java branch February 28, 2022 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants