Handle empty unions via dedicated expression #6408
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
requested review from
kroening,
martin-cs and
peterschrammel
as code owners
|
I should also revisit #5667 once this is merged. |
kroening
reviewed
Oct 21, 2021
src/util/std_expr.h
Outdated
| class empty_union_exprt : public nullary_exprt | ||
| { | ||
| public: | ||
| empty_union_exprt(typet _type) |
There was a problem hiding this comment.
I'd make that constructor explicit.
kroening
approved these changes
Oct 21, 2021
tautschnig
force-pushed
the
empty-union
branch
from
77675d6 to
ef1ae12
Compare
martin-cs
approved these changes
Oct 21, 2021
I don't think that would be a problem, as long as you never try to access any bytes in there. |
tautschnig
force-pushed
the
empty-union
branch
2 times, most recently
from
243bf48 to
79b7014
Compare
GCC and Clang support empty unions, which the C standard does not permit. We previously handled this special case by generating nil. This, however, is not supported by the bitvector back-end. Rather than coming up with selective handling of the otherwise unexpected nil, a proper expression is introduced (and handled). Fixes: diffblue#6163
tautschnig
force-pushed
the
empty-union
branch
from
79b7014 to
eff2507
Compare
Codecov Report
@@ Coverage Diff @@
## develop #6408 +/- ##
===========================================
- Coverage 75.98% 75.98% -0.01%
===========================================
Files 1523 1524 +1
Lines 164284 164290 +6
===========================================
+ Hits 124839 124843 +4
- Misses 39445 39447 +2
Continue to review full report at Codecov.
|
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GCC and Clang support empty unions, which the C standard does not
permit. We previously handled this special case by generating nil. This,
however, is not supported by the bitvector back-end. Rather than coming
up with selective handling of the otherwise unexpected nil, a proper
expression is introduced (and handled).
Fixes: #6163