Skip to content

change make_return method name and signature #6407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 21, 2021
Merged

Conversation

kroening
Copy link
Member

The method creates a 'set return value' instruction, and the new name reflects that.

The method now takes the return value as argument, and not a code_returnt expression.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@codecov
Copy link

codecov bot commented Oct 21, 2021

Codecov Report

Merging #6407 (4b740c2) into develop (cd36425) will increase coverage by 0.00%.
The diff coverage is 94.52%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #6407   +/-   ##
========================================
  Coverage    75.98%   75.98%           
========================================
  Files         1523     1524    +1     
  Lines       164275   164283    +8     
========================================
+ Hits        124830   124838    +8     
  Misses       39445    39445           
Impacted Files Coverage Δ
src/ansi-c/c_typecheck_base.h 100.00% <ø> (ø)
src/goto-programs/goto_convert_class.h 87.30% <ø> (ø)
src/goto-symex/goto_symex.h 92.30% <ø> (ø)
src/goto-symex/symex_builtin_functions.cpp 93.60% <ø> (ø)
src/jsil/jsil_parse_tree.cpp 0.00% <0.00%> (ø)
src/jsil/jsil_typecheck.cpp 0.00% <0.00%> (ø)
src/jsil/jsil_typecheck.h 0.00% <ø> (ø)
unit/goto-programs/goto_program_validate.cpp 100.00% <ø> (ø)
src/goto-symex/symex_function_call.cpp 93.18% <88.00%> (ø)
src/util/std_code_base.h 93.54% <93.54%> (ø)
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8dfeb1a...4b740c2. Read the comment docs.

The method creates a 'set return value' instruction, and the new name reflects that.

The method now takes the return value as argument, and not a code_returnt expression.
@kroening kroening merged commit 7e976e3 into develop Oct 21, 2021
@kroening kroening deleted the set_return_value branch October 21, 2021 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants