Skip to content

cmdlinet::get_comma_separated_values: re-use split_string #6364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 30, 2021

Conversation

tautschnig
Copy link
Collaborator

Instead of (re-)implementing string parsing, use the existing
split_string function to turn comma-separated values into a sequence of
elements.

While at it, also teach cmdlinet::get_comma_separated_values to handle
multiple occurrences of the same option, and document that method.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@tautschnig tautschnig self-assigned this Sep 30, 2021
Instead of (re-)implementing string parsing, use the existing
split_string function to turn comma-separated values into a sequence of
elements.

While at it, also teach cmdlinet::get_comma_separated_values to handle
multiple occurrences of the same option, and document that method.
@codecov
Copy link

codecov bot commented Sep 30, 2021

Codecov Report

Merging #6364 (1c74f17) into develop (54a50e9) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6364      +/-   ##
===========================================
- Coverage    75.91%   75.91%   -0.01%     
===========================================
  Files         1517     1517              
  Lines       164024   164022       -2     
===========================================
- Hits        124515   124513       -2     
  Misses       39509    39509              
Impacted Files Coverage Δ
src/util/cmdline.h 66.66% <ø> (ø)
src/util/cmdline.cpp 95.32% <100.00%> (-0.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d77bf9...1c74f17. Read the comment docs.

@tautschnig tautschnig merged commit 18760ca into diffblue:develop Sep 30, 2021
@tautschnig tautschnig deleted the csv_cleanup branch September 30, 2021 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants