Handle functions with mangled names in contract replacement

[feliperodri]

Signed-off-by: Felipe R. Monteiro [email protected]

In some cases, we use source_location to retrieve information (e.g., function name). However, if we are consuming a goto_programt, but also care about the name of that function, then it must be passed separately. We should not try to infer it via some means, such as the source location. In this case, apply_function_contract must also consume a function_id, so we can properly retrieve the symbol for the caller function.

• Each commit message has a non-empty body, explaining why the change was made.
• Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
• The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
• Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
• My commit message includes data points confirming performance improvements (if claimed).
• My PR is restricted to a single feature or bugfix.
• White-space or formatting changes outside the feature-related changed lines are in commits of their own.

[codecov]

Codecov Report

Merging #6363 (790ad51) into develop (35bd785) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 790ad51 differs from pull request most recent head ec9ac5f. Consider uploading reports for the commit ec9ac5f to get more accurate results

@@           Coverage Diff            @@
##           develop    #6363   +/-   ##
========================================
  Coverage    75.90%   75.90%           
========================================
  Files         1515     1515           
  Lines       164004   164005    +1     
========================================
+ Hits        124483   124484    +1     
  Misses       39521    39521           

Impacted Files	Coverage Δ
src/goto-instrument/contracts/contracts.h	100.00% <ø> (ø)
src/goto-instrument/contracts/contracts.cpp	94.16% <100.00%> (+0.01%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98bbe74...ec9ac5f. Read the comment docs.

[SaswatPadhi]

LGTM. Thanks! :D