Skip to content

Check frame conditions before __CPROVER_havoc_object #6352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 20, 2021

Conversation

feliperodri
Copy link
Collaborator

Signed-off-by: Felipe R. Monteiro [email protected]

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@feliperodri feliperodri added bugfix aws Bugs or features of importance to AWS CBMC users Code Contracts Function and loop contracts labels Sep 20, 2021
@feliperodri feliperodri self-assigned this Sep 20, 2021
Copy link
Contributor

@SaswatPadhi SaswatPadhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Only minor comments below.

@codecov
Copy link

codecov bot commented Sep 20, 2021

Codecov Report

Merging #6352 (f7ff4bf) into develop (860d60d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head f7ff4bf differs from pull request most recent head 7075866. Consider uploading reports for the commit 7075866 to get more accurate results
Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #6352   +/-   ##
========================================
  Coverage    75.90%   75.90%           
========================================
  Files         1515     1515           
  Lines       164005   164021   +16     
========================================
+ Hits        124484   124500   +16     
  Misses       39521    39521           
Impacted Files Coverage Δ
src/goto-instrument/contracts/contracts.cpp 94.17% <100.00%> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c67c340...7075866. Read the comment docs.

@feliperodri feliperodri force-pushed the frame-condition-havoc-fix branch from 96a15e3 to 7075866 Compare September 20, 2021 21:46
@feliperodri feliperodri merged commit c0d742b into diffblue:develop Sep 20, 2021
@feliperodri feliperodri deleted the frame-condition-havoc-fix branch September 20, 2021 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aws Bugs or features of importance to AWS CBMC users bugfix Code Contracts Function and loop contracts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants