Smt unknown handling #6221
Merged
Smt unknown handling #6221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently it is possible for z3 (and maybe other SMT solvers) to return a satisfiability result of "unknown". At the moment this is treated as an ERROR outcome in cbmc. This commit changes the error message handling to output why the result was ERROR by reporting the "unknown" satisfiability result.
TGWDB
requested review from
allredj,
kroening,
martin-cs,
peterschrammel,
romainbrenguier and
tautschnig
as code owners
TGWDB
force-pushed
the
SMT-unknown-handling
branch
from
ad626fd to
d58ea4d
Compare
Codecov Report
@@ Coverage Diff @@
## develop #6221 +/- ##
===========================================
+ Coverage 67.40% 75.30% +7.90%
===========================================
Files 1157 1458 +301
Lines 95236 161436 +66200
===========================================
+ Hits 64197 121575 +57378
- Misses 31039 39861 +8822
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
TGWDB
force-pushed
the
SMT-unknown-handling
branch
from
d58ea4d to
141f3ce
Compare
This adds a regression test for the SMT solver (here z3) returning a satisfiability result of "unknown" and reporting this to the user
kroening
approved these changes
Jul 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible for an SMT solver to return
unknownas the result of satisfiability incbmcat the moment. This PR changes the output to the user to make it clear that this is where theERRORresult comes from and also includes a regression test for this behaviour usingz3.