VSD - bool intervals go top #6209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Intervals with range [min(type), max(type)] go top. However, by extension [FALSE, TRUE] should also go top. This change extends the TOP check constructing interval_abstract_values to cover intervals of type bool and c_bool.
jezhiggins
force-pushed
the
vsd-bool-intervals-go-top
branch
3 times, most recently
from
febc042 to
192eee5
Compare
martin-cs
approved these changes
Jul 2, 2021
jezhiggins
requested review from
chrisr-diffblue and
peterschrammel
as code owners
jezhiggins
force-pushed
the
vsd-bool-intervals-go-top
branch
from
192eee5 to
0a0a862
Compare
Codecov Report
@@ Coverage Diff @@
## develop #6209 +/- ##
===========================================
- Coverage 75.39% 75.20% -0.19%
===========================================
Files 1456 1458 +2
Lines 161216 161311 +95
===========================================
- Hits 121544 121318 -226
- Misses 39672 39993 +321
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An interval which spans its type's [min-max] goes TOP. By extension, a bool interval spanning [FALSE,TRUE] should also go TOP.
This PR makes the changes to
interval_abstract_valuetto add this behaviour.It also extends value-sets to set { FALSE, TRUE } to TOP.