Skip to content

SMT parser: function sorts -> and lambda terms #6202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 27, 2021
Merged

Conversation

kroening
Copy link
Member

@kroening kroening commented Jun 26, 2021

This adds support for parsing the candidate SMT-LIB 3 function sorts and lambda terms.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@kroening kroening force-pushed the smt2_function_sort branch from 664ebe1 to 3de0601 Compare June 26, 2021 10:20
@codecov
Copy link

codecov bot commented Jun 26, 2021

Codecov Report

Merging #6202 (3804b18) into develop (0002950) will increase coverage by 7.54%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6202      +/-   ##
===========================================
+ Coverage    67.40%   74.95%   +7.54%     
===========================================
  Files         1157     1456     +299     
  Lines        95236   161167   +65931     
===========================================
+ Hits         64197   120807   +56610     
- Misses       31039    40360    +9321     
Flag Coverage Δ
cproversmt2 ?
regression ?
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/util/string_container.cpp 52.94% <0.00%> (-47.06%) ⬇️
src/solvers/prop/prop.cpp 42.85% <0.00%> (-41.76%) ⬇️
src/solvers/flattening/boolbv_member.cpp 53.65% <0.00%> (-38.65%) ⬇️
src/cpp/cpp_storage_spec.cpp 65.00% <0.00%> (-35.00%) ⬇️
src/util/cmdline.h 66.66% <0.00%> (-33.34%) ⬇️
src/solvers/strings/array_pool.h 66.66% <0.00%> (-33.34%) ⬇️
src/solvers/strings/string_refinement.h 66.66% <0.00%> (-33.34%) ⬇️
...rs/strings/string_concatenation_builtin_function.h 0.00% <0.00%> (-33.34%) ⬇️
src/cbmc/c_test_input_generator.cpp 60.00% <0.00%> (-30.33%) ⬇️
src/ansi-c/c_typecheck_base.cpp 54.39% <0.00%> (-26.51%) ⬇️
... and 1435 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a04436...3804b18. Read the comment docs.

polgreen and others added 3 commits June 26, 2021 14:44
This adds support for parsing the candidate SMT-LIB 3 function sorts.
Meaningful usage requires lambda expressions, which will follow as separate
commit.
This is a refactoring that enables re-use of the code for parsing a binding.
This uses the existing code for parsing bindings to parse lambda
expressions.
@kroening kroening force-pushed the smt2_function_sort branch from 3de0601 to 3804b18 Compare June 26, 2021 13:49
@kroening kroening changed the title SMT parser: function sorts -> SMT parser: function sorts -> and lambda terms Jun 26, 2021
@kroening kroening marked this pull request as ready for review June 26, 2021 16:01
@kroening kroening merged commit 953871e into develop Jun 27, 2021
@kroening kroening deleted the smt2_function_sort branch June 27, 2021 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants