Skip to content

Add for_each_predecessor() to grapht #6160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 31, 2021

Conversation

johnfxgalea
Copy link
Contributor

@johnfxgalea johnfxgalea commented May 30, 2021

Adds for_each_predecessor() to grapht, along with some tests.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@codecov
Copy link

codecov bot commented May 30, 2021

Codecov Report

Merging #6160 (538070c) into develop (35a5f17) will increase coverage by 0.03%.
The diff coverage is 95.23%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6160      +/-   ##
===========================================
+ Coverage    74.92%   74.95%   +0.03%     
===========================================
  Files         1450     1450              
  Lines       158265   158274       +9     
===========================================
+ Hits        118575   118632      +57     
+ Misses       39690    39642      -48     
Impacted Files Coverage Δ
unit/util/graph.cpp 99.30% <95.00%> (-0.70%) ⬇️
src/util/graph.h 97.29% <100.00%> (+<0.01%) ⬆️
src/ansi-c/ansi_c_entry_point.cpp 66.04% <0.00%> (-21.40%) ⬇️
src/ansi-c/c_typecheck_type.cpp 63.54% <0.00%> (-12.85%) ⬇️
src/util/json.cpp 85.58% <0.00%> (-1.81%) ⬇️
src/util/rename_symbol.cpp 79.09% <0.00%> (+1.81%) ⬆️
src/ansi-c/c_typecast.cpp 79.17% <0.00%> (+3.56%) ⬆️
src/util/validate_code.cpp 85.00% <0.00%> (+5.00%) ⬆️
src/ansi-c/type2name.cpp 89.94% <0.00%> (+5.02%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26f9de7...538070c. Read the comment docs.

@tautschnig tautschnig merged commit d7df1a2 into diffblue:develop May 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants