java_static_lifetime_init: Deterministic order of initialisation

[tautschnig]

Much like the C front-end, ensure that the collection of objects of
static lifetime is initialised in a fixed order, based on their names.
Previously, the (unspecified) order in an unordered set and unordered
map determined the sequence of instructions being generated, which
resulted in jdiff regression tests sometimes failing. Those failures
were caused by __CPROVER_initialize sometimes showing up among the list
of goto functions that differed.

The functional change is the second commit, the first just does the refactoring to make the second commit as small (and as easy to review) as possible.

• Each commit message has a non-empty body, explaining why the change was made.
• Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
• n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
• Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
• n/a My commit message includes data points confirming performance improvements (if claimed).
• My PR is restricted to a single feature or bugfix.
• n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

[codecov]

Codecov Report

Merging #6093 (3258d81) into develop (c4deb56) will increase coverage by 0.00%.
The diff coverage is 92.42%.

@@           Coverage Diff            @@
##           develop    #6093   +/-   ##
========================================
  Coverage    75.98%   75.99%           
========================================
  Files         1524     1524           
  Lines       164244   164249    +5     
========================================
+ Hits        124809   124814    +5     
  Misses       39435    39435           

Impacted Files	Coverage Δ
jbmc/src/java_bytecode/java_entry_point.cpp	89.52% <92.42%> (+0.16%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62dc70a...3258d81. Read the comment docs.

[tautschnig]

@peterschrammel Ping?