-
Notifications
You must be signed in to change notification settings - Fork 273
Introduce ansi-c/c_expr.h #5923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #5923 +/- ##
========================================
Coverage 75.01% 75.02%
========================================
Files 1431 1431
Lines 155609 155563 -46
========================================
- Hits 116732 116708 -24
+ Misses 38877 38855 -22
Continue to review full report at Codecov.
|
Trying to figure out why check-cpplint isn't failing here, as it should. Working on this in #5929. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not (yet) convinced: a further (assembler) and one stronger (goto-programs) dependency on ansi-c doesn't seem right.
src/assembler/remove_asm.cpp
Outdated
@@ -15,6 +15,8 @@ Date: December 2014 | |||
|
|||
#include "remove_asm.h" | |||
|
|||
#include <ansi-c/c_expr.h> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
src/assembler/module_dependencies.txt
does not currently list ansi-c
, so we're introducing a new dependency on ansi-c here. And, really, this means that the expression is not limited to the C front-end.
This introduces a new header file, ansi-c/c_expr.h, which is to collect expressions that are specific to and internal to the C frontend.
This introduces a new header file, ansi-c/c_expr.h, which is to collect
expressions that are specific to and internal to the C frontend.