Skip to content

Use ccache in codecov-coverage-report GitHub action #5909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 12, 2021

Conversation

tautschnig
Copy link
Collaborator

The GitHub action takes by far the longest, and while the execution time
likely is dominated by test execution we should not unnecessarily waste
time for compiling.

Performance data will be added to the commit message.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@tautschnig tautschnig self-assigned this Mar 10, 2021
@codecov
Copy link

codecov bot commented Mar 10, 2021

Codecov Report

Merging #5909 (a0d1047) into develop (e5e4a18) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #5909   +/-   ##
========================================
  Coverage    73.55%   73.55%           
========================================
  Files         1430     1430           
  Lines       155222   155222           
========================================
  Hits        114170   114170           
  Misses       41052    41052           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51c59e9...a0d1047. Read the comment docs.

Copy link
Contributor

@NlightNFotis NlightNFotis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely needed, thanks for the addition of this!

@tautschnig tautschnig force-pushed the codecov-ccache branch 16 times, most recently from 4816207 to 64e287d Compare March 12, 2021 15:27
The GitHub action takes by far the longest, and while the execution time
likely is dominated by test execution we should not unnecessarily waste
time for compiling.

Building previously took more than 20 minutes, and now takes around 3
minutes instead. The ccache size has to be set to at least 2 GB to avoid
cache entries being removed during build, but the packed archive of
cache results is below 500 MB, which should be safe as far as our use of
the 5 GB of total cache storage is concerned.
@tautschnig tautschnig marked this pull request as ready for review March 12, 2021 20:51
@tautschnig tautschnig requested a review from a team as a code owner March 12, 2021 20:51
@tautschnig tautschnig merged commit ae4dca8 into diffblue:develop Mar 12, 2021
@tautschnig tautschnig deleted the codecov-ccache branch March 12, 2021 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants