Skip to content

Include width in format() output of raw bitvector type #5889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 8, 2021

Conversation

tautschnig
Copy link
Collaborator

ID_bv is also a bitvector type, and should thus be printed with a width,
just like signed/unsigned bv.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

ID_bv is also a bitvector type, and should thus be printed with a width,
just like signed/unsigned bv.
@tautschnig tautschnig self-assigned this Mar 7, 2021
@codecov
Copy link

codecov bot commented Mar 7, 2021

Codecov Report

Merging #5889 (b3a128e) into develop (45b6d72) will increase coverage by 0.07%.
The diff coverage is 97.64%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5889      +/-   ##
===========================================
+ Coverage    72.95%   73.03%   +0.07%     
===========================================
  Files         1425     1429       +4     
  Lines       154281   154698     +417     
===========================================
+ Hits        112561   112980     +419     
+ Misses       41720    41718       -2     
Impacted Files Coverage Δ
...ses/variable-sensitivity/constant_abstract_value.h 100.00% <ø> (ø)
...s/variable-sensitivity/value_set_abstract_object.h 100.00% <ø> (ø)
unit/analyses/variable-sensitivity/eval.cpp 100.00% <ø> (ø)
src/util/format_type.cpp 48.21% <50.00%> (+0.06%) ⬆️
...lyses/variable-sensitivity/abstract_value_object.h 84.74% <83.63%> (-15.26%) ⬇️
...ses/variable-sensitivity/abstract_value_object.cpp 95.31% <95.88%> (+7.07%) ⬆️
...variable-sensitivity/value_set_abstract_object.cpp 86.99% <97.87%> (-4.73%) ⬇️
...-sensitivity/variable_sensitivity_test_helpers.cpp 98.23% <98.23%> (ø)
...lyses/variable-sensitivity/abstract_object_set.cpp 100.00% <100.00%> (ø)
...nalyses/variable-sensitivity/abstract_object_set.h 100.00% <100.00%> (ø)
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa12ca7...b3a128e. Read the comment docs.

@kroening kroening merged commit d1f29d4 into diffblue:develop Mar 8, 2021
@tautschnig tautschnig deleted the bv-output branch March 8, 2021 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants