Skip to content

Make computation of widest union member widely available #5746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 14, 2021

Conversation

tautschnig
Copy link
Collaborator

This functionality is of use beyond byte-operator lowering.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

This functionality is of use beyond byte-operator lowering. Actual
additional uses will be introduced in subsequent commits.
This should make it safer to use and enables re-use as part of
pointer_offset_bits.
@tautschnig tautschnig force-pushed the find_widest_union_component branch from dacb439 to 4acaa86 Compare January 14, 2021 08:29
@codecov
Copy link

codecov bot commented Jan 14, 2021

Codecov Report

Merging #5746 (4acaa86) into develop (bc6b109) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5746      +/-   ##
===========================================
- Coverage    69.55%   69.55%   -0.01%     
===========================================
  Files         1243     1243              
  Lines       100721   100719       -2     
===========================================
- Hits         70054    70052       -2     
  Misses       30667    30667              
Flag Coverage Δ
cproversmt2 43.29% <94.11%> (-0.01%) ⬇️
regression 66.46% <82.35%> (+<0.01%) ⬆️
unit 32.22% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/util/std_types.h 94.46% <ø> (ø)
src/solvers/lowering/byte_operators.cpp 83.76% <100.00%> (-0.21%) ⬇️
src/util/pointer_offset_size.cpp 94.80% <100.00%> (-0.04%) ⬇️
src/util/std_types.cpp 90.81% <100.00%> (+1.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc6b109...4acaa86. Read the comment docs.

@tautschnig tautschnig merged commit b8a80cb into diffblue:develop Jan 14, 2021
@tautschnig tautschnig deleted the find_widest_union_component branch January 14, 2021 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants