Skip to content

Follow-up to 090790a467: attribute __used__ requires unique names #5729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 7, 2022

Conversation

tautschnig
Copy link
Collaborator

With 090790a we made sure that symbols marked with
attribute((used)) are not discarded. Linking multiple files that
use symbols marked as such still must not result in conflicting
declarations on such symbols, thus use the DJB name mangler to generate
unique names.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@codecov
Copy link

codecov bot commented Jan 8, 2021

Codecov Report

Base: 78.34% // Head: 78.26% // Decreases project coverage by -0.08% ⚠️

Coverage data is based on head (9fd1769) compared to base (a53fa0f).
Patch coverage: 90.00% of modified lines in pull request are covered.

❗ Current head 9fd1769 differs from pull request most recent head 9298526. Consider uploading reports for the commit 9298526 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5729      +/-   ##
===========================================
- Coverage    78.34%   78.26%   -0.09%     
===========================================
  Files         1644     1642       -2     
  Lines       190313   189748     -565     
===========================================
- Hits        149097   148498     -599     
- Misses       41216    41250      +34     
Impacted Files Coverage Δ
src/ansi-c/ansi_c_declaration.h 95.00% <ø> (-0.24%) ⬇️
src/ansi-c/c_typecheck_base.cpp 83.78% <85.71%> (+0.19%) ⬆️
src/ansi-c/ansi_c_declaration.cpp 74.03% <100.00%> (-0.04%) ⬇️
src/goto-symex/solver_hardness.cpp 53.00% <0.00%> (-6.00%) ⬇️
src/util/byte_operators.cpp 90.00% <0.00%> (-3.11%) ⬇️
src/solvers/smt2/smt2_conv.cpp 66.43% <0.00%> (-2.18%) ⬇️
src/util/expr_initializer.cpp 83.33% <0.00%> (-1.78%) ⬇️
src/goto-programs/goto_program.cpp 80.24% <0.00%> (-1.56%) ⬇️
...ncremental/smt2_incremental_decision_procedure.cpp 98.09% <0.00%> (-0.67%) ⬇️
src/solvers/flattening/arrays.cpp 79.83% <0.00%> (-0.54%) ⬇️
... and 59 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

With 090790a we made sure that symbols marked with
__attribute__((__used__)) are not discarded. Linking multiple files that
use symbols marked as such still must not result in conflicting
declarations on such symbols, thus use the DJB name mangler to generate
unique names.
@peterschrammel peterschrammel removed their assignment Dec 6, 2022
@tautschnig tautschnig merged commit 65af274 into diffblue:develop Dec 7, 2022
@tautschnig tautschnig deleted the attribute-used branch December 7, 2022 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants