Skip to content

Remove exprt::make_bool #5550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 7, 2020
Merged

Remove exprt::make_bool #5550

merged 1 commit into from
Nov 7, 2020

Conversation

kroening
Copy link
Member

@kroening kroening commented Nov 7, 2020

This method has been deprecated since June 2019, there are no in-tree uses
of this function and there is a simple substitute for external users.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • n/a My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

This method has been deprecated since June 2019, there are no in-tree uses
of this function and there is a simple substitute for external users.
@codecov
Copy link

codecov bot commented Nov 7, 2020

Codecov Report

Merging #5550 (22d448b) into develop (bf62883) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #5550   +/-   ##
========================================
  Coverage    68.52%   68.53%           
========================================
  Files         1187     1187           
  Lines        98265    98262    -3     
========================================
  Hits         67339    67339           
+ Misses       30926    30923    -3     
Flag Coverage Δ
cproversmt2 42.97% <ø> (+<0.01%) ⬆️
regression 65.68% <ø> (+<0.01%) ⬆️
unit 32.26% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/util/expr.cpp 70.33% <ø> (+1.74%) ⬆️
src/util/expr.h 90.69% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf62883...22d448b. Read the comment docs.

@kroening kroening requested a review from allredj November 7, 2020 12:58
@kroening kroening marked this pull request as ready for review November 7, 2020 12:58
@tautschnig tautschnig merged commit 6d5e580 into develop Nov 7, 2020
@tautschnig tautschnig deleted the remove_make_bool branch November 7, 2020 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants