Skip to content

Remove line breaks from the body of the text on the release page. #5522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 14, 2020

Conversation

markrtuttle
Copy link
Collaborator

The yaml file regular-release.yaml generating the release page include
the body of text for the release page. The definition of the body
include line breaks to make the text fit within 80 characters in the
yaml file, but the line breaks in the yaml file are treated as line
breaks in the resulting markdown file, and the text does not flow well
in a web browser.

This page just removes the line breaks within a paragraph of text.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

The yaml file regular-release.yaml generating the release page include
the body of text for the release page.  The definition of the body
include line breaks to make the text fit within 80 characters in the
yaml file, but the line breaks in the yaml file are treated as line
breaks in the resulting markdown file, and the text does not flow well
in a web browser.

This page just removes the line breaks within a paragraph of text.
@codecov
Copy link

codecov bot commented Oct 9, 2020

Codecov Report

Merging #5522 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #5522   +/-   ##
========================================
  Coverage    68.40%   68.40%           
========================================
  Files         1187     1187           
  Lines        98090    98090           
========================================
  Hits         67102    67102           
  Misses       30988    30988           
Flag Coverage Δ
#cproversmt2 42.97% <ø> (ø)
#regression 65.55% <ø> (ø)
#unit 32.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4451960...aac9d61. Read the comment docs.

Copy link
Collaborator

@martin-cs martin-cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be just white-space changes as described. I presume that .yaml files are not linted for line length.

Copy link
Contributor

@chrisr-diffblue chrisr-diffblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@NlightNFotis NlightNFotis merged commit 31f73e1 into diffblue:develop Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants