Fix CMake build on Windows #5437
Conversation
Without them being required, a new build where the binaries of the two programs are not found fails late and with confusing error messages. This makes the build fail fast and early, at the point where the error is produced (where the binaries have failed to have been found).
The CMakeLists.txt was performing a `cp` command directly, which while it was not an issue on linux, if you build on Windows with cmake, it fails the build because the equivalent command is `copy`. I made it so we use the portable interface of the CMake binary to perform the copy across all targets, so it's portable.
NlightNFotis
requested review from
chrisr-diffblue,
kroening,
peterschrammel,
smowton and
tautschnig
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #5437 +/- ##
========================================
Coverage 68.21% 68.21%
========================================
Files 1178 1178
Lines 97561 97561
========================================
Hits 66554 66554
Misses 31007 31007
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## develop #5437 +/- ##
========================================
Coverage 68.21% 68.21%
========================================
Files 1178 1178
Lines 97561 97561
========================================
Hits 66554 66554
Misses 31007 31007
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
| @@ -1,7 +1,7 @@ | |||
| project(CBMC) | |||
|
|
|||
| find_package(BISON) | |||
| find_package(FLEX) | |||
| find_package(BISON REQUIRED) | |||
There was a problem hiding this comment.
👍 it's a non-optional dependency and absolutely should be marked as REQUIRED
| @@ -4,7 +4,7 @@ add_subdirectory(unit) | |||
|
|
|||
| add_custom_target(java-models-library ALL | |||
| COMMAND mvn --quiet -Dmaven.test.skip=true package | |||
| COMMAND cp target/core-models.jar ${CMAKE_CURRENT_SOURCE_DIR}/src/java_bytecode/library/ | |||
| COMMAND ${CMAKE_COMMAND} -E copy target/core-models.jar ${CMAKE_CURRENT_SOURCE_DIR}/src/java_bytecode/library/ | |||
There was a problem hiding this comment.
Yep, we should avoid using unix-y commands in our... commands.
I'd recommend putting all the variable stuff in " quotes as well... I don't actually know off the top of my head how CMake handles variable expansions with whitespace in them.
There was a problem hiding this comment.
It's no worse than the current situation so I'm happy for this to be merged as is - but It probably is worth trying a build on a checkout of CBMC that has spaces in its file path. On Mac/Windows it's not that uncommon for this to happen.
| @@ -4,7 +4,7 @@ add_subdirectory(unit) | |||
|
|
|||
| add_custom_target(java-models-library ALL | |||
| COMMAND mvn --quiet -Dmaven.test.skip=true package | |||
There was a problem hiding this comment.
Not an action for this PR, but we should also avoid hardcoding the maven executable. By adding a configuration for this we could support cases where people want to build with ~/.local/bin/maven-experimental or whatever.
| @@ -4,7 +4,7 @@ add_subdirectory(unit) | |||
|
|
|||
| add_custom_target(java-models-library ALL | |||
| COMMAND mvn --quiet -Dmaven.test.skip=true package | |||
| COMMAND cp target/core-models.jar ${CMAKE_CURRENT_SOURCE_DIR}/src/java_bytecode/library/ | |||
| COMMAND ${CMAKE_COMMAND} -E copy target/core-models.jar ${CMAKE_CURRENT_SOURCE_DIR}/src/java_bytecode/library/ | |||
There was a problem hiding this comment.
It's no worse than the current situation so I'm happy for this to be merged as is - but It probably is worth trying a build on a checkout of CBMC that has spaces in its file path. On Mac/Windows it's not that uncommon for this to happen.
Attempting to build
cbmcwithcmakeonVisual Studio 2019/Win 10fails.This PR introduces some needed changes to two
CMakeLists.txtfiles to makeit work.