Add pretty printing for exprts in Catch assertions #5358
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without a pretty printer exprt's just show up as ? in
catch assertions, which isn't very helpful.
Other things that could be similarly printed are
typet
s and (especially)irep_idt
s. These pretty printers are added from theuse_catch
header because I can’t think of a good reason why we’d need to avoid that, and this avoids annoying ? output when you forget to include an optional header (and UB because we have incompatible template instantiations in headers that don’t include the pretty printer, although that’s unlikely to cause actual problems).