Skip to content

Change doxygen download URL for Travis #5329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2020

Conversation

danpoe
Copy link
Contributor

@danpoe danpoe commented May 1, 2020

The previous download URL doesn't work anymore

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • n/a Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

The previous download URL doesn't work anymore
Copy link
Contributor

@NlightNFotis NlightNFotis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Dan!

@hannes-steffenhagen-diffblue
Copy link
Contributor

We had some concerns about this maybe breaking the doxygen checks on travis, let's wait and see if those work before merging.

@thk123
Copy link
Contributor

thk123 commented May 1, 2020

I'm happy if it works - though should we switch back (and update the version), that way we're using the latest version

@danpoe
Copy link
Contributor Author

danpoe commented May 1, 2020

@hannes-steffenhagen-diffblue This is the same version as we had previously, so all the checks should still pass.

@thk123 Just wanted to get this in quickly so merges on develop aren't blocked. We can later see about switching to the latest version of doxygen. The newest version is also available via the source forge link so we'd just need to change DOXYGEN_VERSION in the travis.yml file.

@codecov-io
Copy link

Codecov Report

Merging #5329 into develop will decrease coverage by 1.54%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5329      +/-   ##
===========================================
- Coverage    68.05%   66.51%   -1.55%     
===========================================
  Files         1170     1170              
  Lines        96421    96421              
===========================================
- Hits         65620    64134    -1486     
- Misses       30801    32287    +1486     
Flag Coverage Δ
#cproversmt2 ?
#regression 64.55% <ø> (ø)
#unit 31.77% <ø> (ø)
Impacted Files Coverage Δ
src/solvers/smt2/letify.cpp 0.00% <0.00%> (-100.00%) ⬇️
src/solvers/smt2/smt2_dec.h 0.00% <0.00%> (-100.00%) ⬇️
src/solvers/floatbv/float_bv.h 0.00% <0.00%> (-100.00%) ⬇️
src/solvers/smt2/smt2irep.cpp 0.00% <0.00%> (-88.00%) ⬇️
src/solvers/floatbv/float_bv.cpp 0.00% <0.00%> (-74.13%) ⬇️
src/solvers/smt2/smt2_dec.cpp 0.00% <0.00%> (-67.70%) ⬇️
src/solvers/smt2/letify.h 33.33% <0.00%> (-66.67%) ⬇️
src/solvers/smt2/smt2_conv.h 36.36% <0.00%> (-63.64%) ⬇️
src/solvers/smt2/smt2_conv.cpp 19.81% <0.00%> (-37.61%) ⬇️
src/solvers/flattening/pointer_logic.cpp 71.21% <0.00%> (-18.19%) ⬇️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03ab5c7...6e45905. Read the comment docs.

@danpoe danpoe merged commit c79f93f into diffblue:develop May 1, 2020
@danpoe danpoe deleted the fixes/change-doxygen-download-url branch June 2, 2020 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants