Skip to content

Fix cmake flag in COMPILING.md and other docs #5208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 2, 2020

Conversation

karkhaz
Copy link
Collaborator

@karkhaz karkhaz commented Dec 26, 2019

The -H flag to cmake was never officially supported; the -S flag should be used instead to specify the source directory. Using -H doesn't work on recent versions of cmake.

@kroening
Copy link
Member

cmake complains "CMake Error: The source directory "" does not exist."
Perhaps simply omit?

The -H flag to cmake was never officially supported; the -S flag should
be used instead to specify the source directory. Using -H doesn't work
on recent versions of cmake.
@karkhaz karkhaz force-pushed the kk-correct-cmake-invocation branch from 30969fc to ac76105 Compare December 26, 2019 21:52
@codecov-io
Copy link

codecov-io commented Dec 26, 2019

Codecov Report

Merging #5208 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #5208   +/-   ##
========================================
  Coverage    67.37%   67.37%           
========================================
  Files         1157     1157           
  Lines        95087    95087           
========================================
  Hits         64068    64068           
  Misses       31019    31019
Flag Coverage Δ
#cproversmt2 42.65% <ø> (ø) ⬆️
#regression 63.89% <ø> (ø) ⬆️
#unit 31.92% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e51ef3...ac76105. Read the comment docs.

Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: ac76105).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/142412611

@karkhaz
Copy link
Collaborator Author

karkhaz commented Dec 27, 2019

Apparently cmake flags are sensitive to whitespace, -S. doesn't work on some platforms but -S . does. What's even weirder is that it doesn't complain about -Bbuild. I have no idea.

Anyway, I fixed the documentation and CI manifests. Thanks.

@karkhaz karkhaz merged commit be84cd1 into diffblue:develop Jan 2, 2020
@karkhaz karkhaz deleted the kk-correct-cmake-invocation branch January 20, 2020 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants