Goto-harness support to selectively havoc struct members #5183
Conversation
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: d9a1bb4).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/136301109
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: f096f4d).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/136317859
| @@ -16,6 +16,7 @@ Author: Diffblue Ltd. | |||
| #define COMMON_HARNESS_GENERATOR_MAX_ARRAY_SIZE_OPT "max-array-size" | |||
| #define COMMON_HARNESS_GENERATOR_FUNCTION_POINTER_CAN_BE_NULL_OPT \ | |||
| "function-pointer-can-be-null" | |||
| #define COMMON_HARNESS_GENERATOR_MEMBER_SELECTION_OPT "member-selection" | |||
There was a problem hiding this comment.
I don’t really like the name member-selection, following the pattern it should be called something like nondet-member or havoc-member
| @@ -85,6 +86,22 @@ bool recursive_initialization_configt::handle_option( | |||
| [](const std::string &opt) -> irep_idt { return irep_idt{opt}; }); | |||
| return true; | |||
| } | |||
| else if(option == COMMON_HARNESS_GENERATOR_MEMBER_SELECTION_OPT) | |||
There was a problem hiding this comment.
Correct me if I’m wrong, but this looks as if you can only have one member havoc'd at a time? Because that shouldn’t be the case.
to goto-harness. By means of a new option `member-selection` the user can now specify a struct-within-struct path, e.g. `struct_outer.struct_inner.data` to specify only which member they want to havoc. Includes a test.
via a comma-separated list. Plus one more test.
xbauch
force-pushed
the
feature/selective-struct-havoc
branch
from
f096f4d to
65bfa60
Compare
xbauch
changed the title
xbauch
requested review from
chrisr-diffblue,
danpoe,
martin-cs and
peterschrammel
as code owners
|
Now we’d probably also want things like “these two fields in this struct can point to the same variable” or “this field in that struct is the length of the array in that struct”, but not in this PR |
By means of a new option
havoc-memberthe user can now specify a struct-within-struct path, e.g.struct_outer.struct_inner.datato specify only which member they want to havoc.Includes a test.