Feature/restrict function pointer by name [depends-on: #5168] #5174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a new option, --restrict-function-pointer, to cbmc. This lets a user specify a list of possible pointer targets for specific function pointer call sites, rather than have remove_function_pointers guess possible values. The intended purpose behind this is to prevent excessive symex time wasted on exploring paths the user knows the program can never actually take.
hannes-steffenhagen-diffblue
requested review from
chrisr-diffblue,
kroening,
peterschrammel,
pkesseli,
smowton and
tautschnig
as code owners
xbauch
reviewed
Nov 6, 2019
| #include <cstdlib> // exit() | ||
| #include <fstream> |
There was a problem hiding this comment.
It looks like you called clang-format on the whole file: maybe a separate commit?
There was a problem hiding this comment.
Nah I'll undo it.
hannes-steffenhagen-diffblue
force-pushed
the
feature/restrict-function-pointer-by-name
branch
from
038bdb4 to
13bf822
Compare
This works similar to restrict-function-pointer, but for names of individual function pointer variables (globals, locals, parameters) rather than call sites. This isn't applicable to all situations (for example, calling function pointers in structs or function pointers returned from functions), but is more readily applicable to some common use scenarios (e.g. global function pointers loaded at start time like in OpenGL).
hannes-steffenhagen-diffblue
force-pushed
the
feature/restrict-function-pointer-by-name
branch
from
13bf822 to
bb617bb
Compare
allredj
reviewed
Nov 7, 2019
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: ee5b42b).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/135430669
karkhaz
approved these changes
Feb 13, 2020
5 tasks
tautschnig
reviewed
Nov 7, 2020
Comment on lines
+53
to
+57
| inline irep_idt string2id(const std::string &id_string) | ||
| { | ||
| return irep_idt{id_string}; | ||
| } | ||
|
|
There was a problem hiding this comment.
This seems unnecessary (and unused)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works similar to restrict-function-pointer, but for names of individual
function pointer variables (globals, locals, parameters) rather than call sites.
This isn't applicable to all situations (for example, calling function pointers
in structs or function pointers returned from functions), but is more readily
applicable to some common use scenarios (e.g. global function pointers loaded at
start time like in OpenGL).