Statement List: Jump instructions #5054
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatWise
requested review from
kroening,
peterschrammel,
pkesseli and
tautschnig
as code owners
|
Travis build fails because of known doxygen issue, works locally. |
tautschnig
force-pushed
the
feature/statement-list-jumps
branch
from
8328937 to
f9b7df4
Compare
tautschnig
approved these changes
May 11, 2021
Codecov Report
@@ Coverage Diff @@
## develop #5054 +/- ##
===========================================
- Coverage 75.68% 75.33% -0.36%
===========================================
Files 1447 1447
Lines 157837 157988 +151
===========================================
- Hits 119465 119013 -452
- Misses 38372 38975 +603
Continue to review full report at Codecov.
|
Changes the accepted format for labels and wraps instructions that have a label in a code label.
Includes parser support for: - JU (unconditional jump) - JC (conditional jump) - JCN (inverted conditional jump)
Just small formatting changes.
Adds support for the verification of jump instructions. Includes both conditional and unconditional jumps. Limitations: This implementation is only a rough concept and will likely be changed in the future. CFGs prove more useful for this task than the current concept, since they allow all parts of the PLC CPU to be modelled implicitly, without exceptions. Currently the state of the CPU needs to be saved as an intermediate result when encountering labels and jumps. This is only realised for logic sequences currently. Jump instructions in blocks that depend on the accumulator will yield to false results!
Sets the typecheck to the correct state for verifying new blocks or networks. Limitations: The accumulator is unaffected by this. It needs to be investigated whether the accumulator gets reset at all in TIA.
tautschnig
force-pushed
the
feature/statement-list-jumps
branch
from
f9b7df4 to
5656450
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes support for the following STL instructions:
Since not all label destinations in STL are valid (this can depend on several conditions), it is needed to introduce data structures which track the properties of label and jump locations to the typecheck. See the documentation for details about the whole strategy.
Limitations: This implementation is only a rough concept and will likely be changed in the future. CFGs prove more useful for this task than the current concept, since they allow all parts of the PLC CPU to be modelled implicitly, without exceptions. Currently the state of the CPU needs to be saved as an intermediate result when encountering labels and jumps. So far this has only been realised for logic sequences. Jump instructions in blocks that depend on the accumulator will yield to false results.