Skip to content

Do not try to generate void objects #4759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 7, 2019

Conversation

tautschnig
Copy link
Collaborator

For void pointers (or structs containing void pointers) we cannot
generate "void" typed objects. Instead, generate char-typed objects as a
fall-back.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@tautschnig tautschnig requested a review from kroening as a code owner June 6, 2019 15:59
@tautschnig tautschnig self-assigned this Jun 6, 2019
@tautschnig
Copy link
Collaborator Author

I still need to add a regression test.

Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: d69fffb).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/114620942

@codecov-io
Copy link

codecov-io commented Jun 6, 2019

Codecov Report

❗ No coverage uploaded for pull request base (develop@0b8c742). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #4759   +/-   ##
==========================================
  Coverage           ?   68.46%           
==========================================
  Files              ?     1271           
  Lines              ?   104874           
  Branches           ?        0           
==========================================
  Hits               ?    71800           
  Misses             ?    33074           
  Partials           ?        0
Impacted Files Coverage Δ
src/ansi-c/c_nondet_symbol_factory.cpp 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b8c742...8a44e73. Read the comment docs.

For void pointers (or structs containing void pointers) we cannot
generate "void" typed objects. Instead, generate char-typed objects as a
fall-back.
@tautschnig
Copy link
Collaborator Author

Test added.

@tautschnig tautschnig assigned kroening and unassigned tautschnig Jun 7, 2019
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: 8a44e73).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/114716600

@kroening kroening merged commit f78cdc5 into diffblue:develop Jun 7, 2019
@tautschnig tautschnig deleted the no-init-void branch June 11, 2019 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants