Skip to content

Print a more helpful message in Java bytecode parsing invariant violation #4668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 17, 2019
Merged

Print a more helpful message in Java bytecode parsing invariant violation #4668

merged 1 commit into from
May 17, 2019

Conversation

forejtv
Copy link
Contributor

@forejtv forejtv commented May 17, 2019

In Java bytecode parsing, we throw an invariant violation when we cannot find and opaque class for which we could infer a field referenced in another method X.m. To make debugging easier, we should be printing not only the field, its class, and referencing method m, but also the referencing class X.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: aab30cb).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/112207762

@tautschnig tautschnig merged commit 58f628c into diffblue:develop May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants