Symex: shortcut the common case of whole-struct initialisation #4567
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smowton
requested review from
kroening,
peterschrammel and
tautschnig
as code owners
tautschnig
approved these changes
Apr 24, 2019
| lhs_field.id() == ID_symbol, | ||
| "member of symbol should be susceptible to field-sensitivity"); | ||
|
|
||
| const exprt &rhs_field = rhs.operands()[i]; |
There was a problem hiding this comment.
I think you'd want a PRECONDITION(rhs.operands().size() == components.size());
| const struct_typet &type = to_struct_type(ns.follow(lhs.type())); | ||
| const struct_union_typet::componentst &components = type.components(); | ||
|
|
||
| for(std::size_t i = 0; i < components.size(); ++i) |
There was a problem hiding this comment.
How about using a ranged for and an iterator over rhs.operands()?
owen-mc-diffblue
approved these changes
Apr 26, 2019
src/goto-symex/symex_assign.cpp
Outdated
| /// This abbreviates the process, directly producing | ||
| /// `x..field1 = 1; x..field2 = 2;` | ||
| /// \param state: goto-symex state | ||
| /// \param lhs: symbol to assign |
There was a problem hiding this comment.
You should mention that it should be L1-renamed already here
Rather than assign a temporary symbol and then expand it, directly extract the fields and assign them. This cuts the time taken on one initialisation-heavy benchmark from 3.6s to 3.2s.
smowton
force-pushed
the
smowton/feature/shortcut-struct-init
branch
from
0b6ab81 to
a1deabe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than assign a temporary symbol and then expand it, directly extract the fields
and assign them. This cuts the time taken on one initialisation-heavy benchmark to symex and print VCCs from 3.6s to 3.2s.