Skip to content

C++ front-end: Declarator to symbol conversion follows C implementation [depends-on: #4559] #4560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2019

Conversation

tautschnig
Copy link
Collaborator

Only the last commit is new, the others are in #4559.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@tautschnig tautschnig force-pushed the c++-attribute-conversion branch from 0b49f13 to a539bfc Compare April 19, 2019 19:30
@tautschnig tautschnig changed the title C++ front-end: Declarator to symbol conversion follows C implementation C++ front-end: Declarator to symbol conversion follows C implementation [depends-on: #4559] Apr 19, 2019
@tautschnig tautschnig force-pushed the c++-attribute-conversion branch 3 times, most recently from c360dbe to 162c4ef Compare April 22, 2019 09:03
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️
This PR failed Diffblue compatibility checks (cbmc commit: c360dbe).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/109122825
Status will be re-evaluated on next push.
Common spurious failures include: the cbmc commit has disappeared in the mean time (e.g. in a force-push); the author is not in the list of contributors (e.g. first-time contributors); compatibility was already broken by an earlier merge.

Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️
This PR failed Diffblue compatibility checks (cbmc commit: 162c4ef).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/109123781
Status will be re-evaluated on next push.
Common spurious failures include: the cbmc commit has disappeared in the mean time (e.g. in a force-push); the author is not in the list of contributors (e.g. first-time contributors); compatibility was already broken by an earlier merge.

@tautschnig tautschnig force-pushed the c++-attribute-conversion branch from 162c4ef to fdf6d30 Compare April 22, 2019 10:37
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️
This PR failed Diffblue compatibility checks (cbmc commit: fdf6d30).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/109127931
Status will be re-evaluated on next push.
Common spurious failures include: the cbmc commit has disappeared in the mean time (e.g. in a force-push); the author is not in the list of contributors (e.g. first-time contributors); compatibility was already broken by an earlier merge.

@tautschnig tautschnig force-pushed the c++-attribute-conversion branch from fdf6d30 to d739d59 Compare April 22, 2019 16:15
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️
This PR failed Diffblue compatibility checks (cbmc commit: d739d59).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/109160757
Status will be re-evaluated on next push.
Common spurious failures include: the cbmc commit has disappeared in the mean time (e.g. in a force-push); the author is not in the list of contributors (e.g. first-time contributors); compatibility was already broken by an earlier merge.

@peterschrammel peterschrammel removed their assignment Apr 24, 2019
tautschnig added a commit that referenced this pull request May 15, 2019
Re-use C type conversion in C++ front-end [blocks: #4560]
@tautschnig tautschnig force-pushed the c++-attribute-conversion branch from d739d59 to ddd472e Compare May 15, 2019 11:58
Now attributes actually end up in the symbol table.
@tautschnig tautschnig force-pushed the c++-attribute-conversion branch from ddd472e to e3ed19e Compare May 15, 2019 13:23
@tautschnig tautschnig merged commit 26406ac into diffblue:develop May 15, 2019
@tautschnig tautschnig deleted the c++-attribute-conversion branch May 15, 2019 14:41
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: e3ed19e).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/111921243

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants