Set declaring_class for string solver implemented methods #4478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasspriggs
requested review from
cesaro,
cristina-david,
NathanJPhillips,
peterschrammel,
pkesseli,
smowton and
thk123
as code owners
The declaring class was not previously set for methods which are implemented by the string solver. This commit sets the declaring class for the initially empty valued method symbols. INVARIANTs are used to check that the declaring class is still set once the value of the symbol has been provided for the methods implemented by the string solver. The non violation of this INVARIANT is tested by all `strings-smoke-tests` which call such methods. For example the tests in `regression/strings-smoke-tests/java_int_to_string` will check that the INVARIANT holds for `Integer.toString`.
All symbols for methods should have a `declaring_class` after conversion. This commit adds INVARIANTs for this condition on returning from `java_bytecode_languaget::convert_single_method`, in order to demonstrate that this condition holds.
thomasspriggs
force-pushed
the
tas/declarator_of_solver_methods
branch
from
71acf6b to
4bc0680
Compare
thk123
approved these changes
Apr 2, 2019
allredj
reviewed
Apr 2, 2019
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: 4bc0680).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/106717166
romainbrenguier
approved these changes
Apr 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The declaring class was not previously set for methods which are
implemented by the string solver. This PR ensures that the declaring class
is set for these method symbols. This is required for downstream repositories
which need to be able to get the declaring class for any method symbol.