Skip to content

byte_extract lowering of pointers [blocks: #2068] #4191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 14, 2019

Conversation

tautschnig
Copy link
Collaborator

Bit operations cannot be performed on pointers, thus type cast them to unsigned
bitvectors first and then convert back the result.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: fc3073c).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/100978945

Bit operations cannot be performed on pointers, thus type cast them to unsigned
bitvectors first and then convert back the result.
@tautschnig tautschnig force-pushed the byte-extract-pointers branch from fc3073c to 004bd27 Compare February 14, 2019 20:52
Copy link
Contributor

@smowton smowton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems sensible

Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: 004bd27).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/101002110

@tautschnig tautschnig merged commit 9b31039 into diffblue:develop Feb 14, 2019
@tautschnig tautschnig deleted the byte-extract-pointers branch February 14, 2019 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants