-
Notifications
You must be signed in to change notification settings - Fork 277
SMT2 strings tests #4015
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SMT2 strings tests #4015
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems ok except as noted below.
regression/smt2_strings/Makefile
Outdated
default: tests.log | ||
|
||
test: | ||
@../test.pl -p -c ../../../src/solvers/smt2_strings |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should that be smt2_solver
instead? Not that it would support the theory, but the above doesn't exist at all...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, fixed.
@@ -0,0 +1 @@ | |||
!*.smt2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would mean that Makefile, CMakeLists.txt, *.desc are also ignore, which doesn't seem right.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand. I need to discard the ignore that is introduced here:
https://github.com/diffblue/cbmc/blob/develop/.gitignore#L59
and which is useful on the regression tests where cbmc is run with the --smt2
option.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, I wasn't aware of that interaction.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that cbmc still writes the file on disk when run with --smt2?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kroening some of the regression tests use --outfile
, e.g. https://github.com/diffblue/cbmc/blob/develop/regression/cbmc/Malloc22/test.desc#L3
817ce97
to
361050f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫
This PR failed Diffblue compatibility checks (cbmc commit: 817ce97).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/99315203
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.
Common spurious failures:
- the cbmc commit has disappeared in the mean time (e.g. in a force-push)
- the author is not in the list of contributors (e.g. first-time contributors).
The incompatibility may have been introduced by an earlier PR. In that case merging this
PR should be avoided unless it fixes the current incompatibility.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✔️
Passed Diffblue compatibility checks (cbmc commit: 361050f).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/99324952
Adds tests for SMT2 string operations. This PR is limited to tests for constant strings. More tests will come later. The main objective is to check support for these operations on external solvers, but that suite will also become useful once string support is added to CBMC SMT2 backend.