Remove no-longer-used system_symbols #3916
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a follow-up to the cleanup done in 2725a05. Creating a system_symbol_libraryt every time a languaget is created (effectively everytime from_expr is called) is costly, because of all the strings being looked up in the string table. On SV-COMP benchmarks, this accounted for 2% of runtime. Furthermore this removes this undesirable dependency on goto-programs from langapi.
thk123
requested review from
kroening,
peterschrammel and
tautschnig
as code owners
3 tasks
tautschnig
approved these changes
Jan 24, 2019
|
The bump has passed, I can no longer approve this PR, but I'm happy for this to be merged. |
allredj
reviewed
Jan 24, 2019
There was a problem hiding this comment.
🚫
This PR failed Diffblue compatibility checks (cbmc commit: de47d44).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/98484638
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.
Common spurious failures:
- the cbmc commit has disappeared in the mean time (e.g. in a force-push)
- the author is not in the list of contributors (e.g. first-time contributors).
The incompatibility may have been introduced by an earlier PR. In that case merging this
PR should be avoided unless it fixes the current incompatibility.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased version of #3605