rw_set: store function identifier alongside instruction reference [blocks: #3126] #3863
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
requested review from
chrisr-diffblue,
martin-cs and
peterschrammel
as code owners
tautschnig
force-pushed
the
function-rw_set
branch
from
1bafa4c to
98483ed
Compare
allredj
reviewed
Jan 21, 2019
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: 98483ed).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/98004628
tautschnig
force-pushed
the
function-rw_set
branch
from
98483ed to
7675860
Compare
We are working towards removing the "function" field from goto_programt::instructionst::instructiont, and thus need to pass the identifier of the function whenever it actually is required. rw_set does not yet make use of this, but will need to once dereferencing is updated to require a function name.
tautschnig
force-pushed
the
function-rw_set
branch
from
7675860 to
d939de9
Compare
allredj
reviewed
Jan 21, 2019
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: d939de9).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/98084304
peterschrammel
approved these changes
Jan 23, 2019
| #ifdef LOCAL_MAY | ||
| , local_may | ||
| , | ||
| local_may | ||
| #endif | ||
| ); // NOLINT(whitespace/parens) | ||
| if(rw_set.empty()) | ||
| continue; | ||
|
|
||
| symbolt new_symbol; |
There was a problem hiding this comment.
Unrelated to the purpose of this PR: I guess this should be using util/fresh_symbol.
There was a problem hiding this comment.
Certainly true, I'll take a look.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are working towards removing the "function" field from
goto_programt::instructionst::instructiont, and thus need to pass the identifier
of the function whenever it actually is required. rw_set does not yet make use
of this, but will need to once dereferencing is updated to require a function
name.