Stop-on-fail verifier [blocks: 3968] #3796
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterschrammel
requested review from
cesaro,
chrisr-diffblue,
cristina-david,
kroening,
pkesseli,
smowton and
tautschnig
as code owners
peterschrammel
force-pushed
the
stop-on-fail-verifier
branch
from
e3eaaa5 to
815fdac
Compare
peterschrammel
requested review from
NathanJPhillips and
thk123
as code owners
peterschrammel
force-pushed
the
stop-on-fail-verifier
branch
from
815fdac to
fb14e9f
Compare
peterschrammel
force-pushed
the
stop-on-fail-verifier
branch
from
fb14e9f to
1758376
Compare
allredj
reviewed
Jan 21, 2019
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: 1758376).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/97973645
tautschnig
approved these changes
Jan 21, 2019
|
|
||
| case resultt::FAIL: | ||
| { | ||
| namespacet ns(goto_model.get_symbol_table()); |
peterschrammel
force-pushed
the
stop-on-fail-verifier
branch
4 times, most recently
from
2d8258f to
2eb7294
Compare
This was referenced Jan 27, 2019
peterschrammel
force-pushed
the
stop-on-fail-verifier
branch
2 times, most recently
from
4dca0b7 to
4b02243
Compare
allredj
reviewed
Jan 28, 2019
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: 4b02243).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/98754158
peterschrammel
changed the title
Stops verification when the first property violation is found.
This was previously one of the bmct modes. Now it is a separate goto verifier.
This used to be one of the bmct modes; now it is a separate goto verifier.
These were special bmct modes. These modes call prop_convts that don't call an actual solver but just output the formula. This behaviour is only supported with --stop-on-fail; hence, we use the stop-on-fail verifier now.
These were special bmct modes. These modes call prop_convts that don't call an actual solver but just output the formula. This behaviour is only supported with --stop-on-fail; hence, we use the stop-on-fail verifier now.
w.r.t. stop-on-fail goto verifier
peterschrammel
force-pushed
the
stop-on-fail-verifier
branch
from
4b02243 to
3b71199
Compare
peterschrammel
changed the title
allredj
reviewed
Jan 31, 2019
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: 3b71199).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/99353532
smowton
approved these changes
Feb 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #3795, only review last 5 commits.