Skip to content

Do not shadow size variable [blocks: #2310] #3340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 10, 2018

Conversation

tautschnig
Copy link
Collaborator

The requested allocation size is different from the specific reference into the
array, which is later on used to replace the array size. Different names will
help avoid any confusion.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

The requested allocation size is different from the specific reference into the
array, which is later on used to replace the array size. Different names will
help avoid any confusion.
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: b6fcb94).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/90950791

@kroening kroening merged commit 18328db into diffblue:develop Nov 10, 2018
@tautschnig tautschnig deleted the vs-shadow-size branch November 10, 2018 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants